[main] replace rootbrowse.py with C++ version #19722
Conversation
silverweed
force-pushed
the
rootbrowse_cxx
branch
from
28f1346 to
797cf93
Compare
Test Results 21 files 21 suites 4d 1h 41m 31s ⏱️ For more details on these failures, see this check. Results for commit b717f19. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Reporting from my MacOS 15 machine:
- calling
rootbrowseby default starts the webgui, which just hangs and does not produce anything on screen:
08:56:03 (rootdev) vpadulan@vpadulan-macbook rootproject → rootbrowse
ROOT comes with a web-based browser, which is now being started.
Revert to TBrowser by setting "Browser.Name: TRootBrowser" in rootrc file or
by starting "root --web=off"
Find more info on https://root.cern/for_developers/root7/#rbrowser
Info in <THttpEngine::Create>: Starting HTTP server on port 127.0.0.1:8846
Press ctrl+c to exit.
- setting "Browser.Name: TRootBrowser" in rootrc does not work,
rootbrowsedoes not pick up the option and still tries to start the web graphics
@linev the fact that the web graphics hang on MacOS is troublesome
@vepadulano I see no problem on my Mac with master branch. or It is troublesome that simple commands is not know to everybody. |
|
What command do you mean specifically? I'm just testing |
|
Old There is PR which provides reasonable solution for python on all platforms - including Windows and Mac. It is pending since January. |
|
@linev Vincenzo was referring to this version of rootbrowse, so Python is not involved. We later found that the web graphics was not actually "hanging", but rather opening a window in another desktop without moving automatically to it - this is obviously better than hanging, but still not a great experience for a user. Is it expected to do that or should the web window also get focused automatically (like the classic graphics do)? |
silverweed
force-pushed
the
rootbrowse_cxx
branch
from
c4a9972 to
99d004f
Compare
I do not have control over desktop applications when starting external browser via the shell functionality. |
Similarly to #19305 with rootls, this PR replaces
rootbrowse.pywith a native version.Since rootbrowse is just a thin wrapper over TBrowser, this change is much smaller than for rootls and should be quite straightforward.
NOTE: the new rootbrowse is currently untested on Windows and Mac, so before merging this I would much appreciate if someone could help me with that.
Checklist: